L1S(Nano): add subpackage L1TriggerScouting/NanoAOD#50941
Conversation
Move most of the NanoAOD source code specific to L1-Scouting to a dedicated subpackage named L1TriggerScouting/NanoAOD.
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50941/49346
|
|
A new Pull Request was created by @missirol for master. It involves the following packages:
The following packages do not have a category, yet: L1TriggerScouting/NanoAOD @battibass, @cmsbuild, @davidlange6, @emeschi, @fabiocos, @ftenchini, @ftorrresd, @mandrenguyen, @smorovic can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
Pull request #50941 was updated. @BenjaminRS, @battibass, @cmsbuild, @davidlange6, @emeschi, @fabiocos, @ftenchini, @ftorrresd, @mandrenguyen, @quinnanm, @smorovic can you please check and sign again. |
|
please test |
|
+1 Size: This PR adds an extra 16KB to repository Comparison SummarySummary:
|
|
No warnings/errors, and no DQM differences (modulo #47071), in the outputs of the tests, as expected. It might be worth adding the "nano" workflows to the tests (e.g. |
|
enable nano |
|
+1 Size: This PR adds an extra 16KB to repository Comparison SummarySummary:
Nano size comparison Summary:
NANO Comparison SummarySummary:
|
|
DYToll01234Jets_5f_LO_MLM_Madgraph_LHE_13TeV shows a big change but I'm guessing it's unrelated? |
|
+1 |
Mh, good catch. Yes, I think it's unrelated.
As to why this wf behaves this way, I don't know.
The latter questions are maybe for XPOG or GEN, and anyway beyond the scope of this PR. |
|
+l1 |
|
We confirm that the behaviour of |
|
+xpog |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @ftenchini (and backports should be raised in the release meeting by the corresponding L2) |
Fwiw, out of curiosity I checked what happens with a few different gridpacks, and I think I get non-reproducible LHE outputs with [1], and reproducible ones with [2]. I didn't investigate further (the "issue" might be due to using an old version of MadGraph, or CMSSW, or else; the problem occurs with both [1] The first one corresponds to the one currently used in wf [2] |
|
+1 |
PR description:
This PR addresses #50636, moving (most of) the NanoAOD source code specific to L1-Scouting to a new subpackage named
L1TriggerScouting/NanoAOD(assigned to L1T and XPOG in cms-sw/cms-bot#2752).Minor cleanup of
#includestatements in some of the files involved was also done in the process.Merely technical, no changes expected.
PR validation:
The
nanoworkflows passed, i.e.If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:
No backports needed.