Skip to content

L1S(Nano): add subpackage L1TriggerScouting/NanoAOD#50941

Merged
cmsbuild merged 1 commit into
cms-sw:masterfrom
missirol:devel_cmssw50636
May 20, 2026
Merged

L1S(Nano): add subpackage L1TriggerScouting/NanoAOD#50941
cmsbuild merged 1 commit into
cms-sw:masterfrom
missirol:devel_cmssw50636

Conversation

@missirol
Copy link
Copy Markdown
Contributor

PR description:

This PR addresses #50636, moving (most of) the NanoAOD source code specific to L1-Scouting to a new subpackage named L1TriggerScouting/NanoAOD (assigned to L1T and XPOG in cms-sw/cms-bot#2752).

Minor cleanup of #include statements in some of the files involved was also done in the process.

Merely technical, no changes expected.

PR validation:

The nano workflows passed, i.e.

runTheMatrix.py -w nano -l all --ibeos

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

No backports needed.

Move most of the NanoAOD source code specific to L1-Scouting
to a dedicated subpackage named L1TriggerScouting/NanoAOD.
@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented May 14, 2026

cms-bot internal usage

@cmsbuild
Copy link
Copy Markdown
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50941/49346

@cmsbuild
Copy link
Copy Markdown
Contributor

A new Pull Request was created by @missirol for master.

It involves the following packages:

  • Configuration/EventContent (operations)
  • L1TriggerScouting/NanoAOD (****)
  • L1TriggerScouting/Utilities (daq)
  • PhysicsTools/NanoAOD (xpog)

The following packages do not have a category, yet:

L1TriggerScouting/NanoAOD
Please create a PR for https://github.com/cms-sw/cms-bot/blob/master/categories_map.py to assign category

@battibass, @cmsbuild, @davidlange6, @emeschi, @fabiocos, @ftenchini, @ftorrresd, @mandrenguyen, @smorovic can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @Mmiglio, @fabiocos, @gpetruc, @mmusich this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Copy Markdown
Contributor

Pull request #50941 was updated. @BenjaminRS, @battibass, @cmsbuild, @davidlange6, @emeschi, @fabiocos, @ftenchini, @ftorrresd, @mandrenguyen, @quinnanm, @smorovic can you please check and sign again.

@smorovic
Copy link
Copy Markdown
Contributor

please test

@cmsbuild
Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-edfe14/53304/summary.html
COMMIT: 74ba185
CMSSW: CMSSW_17_0_X_2026-05-18-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/50941/53304/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4187292
  • DQMHistoTests: Total failures: 36
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4187236
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
  • Checked 227 log files, 197 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Copy Markdown
Contributor Author

No warnings/errors, and no DQM differences (modulo #47071), in the outputs of the tests, as expected.

It might be worth adding the "nano" workflows to the tests (e.g. enable nano), but that's for reviewers to decide.

@quinnanm
Copy link
Copy Markdown
Contributor

enable nano

@cmsbuild
Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-edfe14/53318/summary.html
COMMIT: 74ba185
CMSSW: CMSSW_17_0_X_2026-05-18-1100/el8_amd64_gcc13
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/50941/53318/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

Nano size comparison Summary:

workflow id kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
NANOmc106Xul16v2 2500.0001 3.094 3.094 0.000 ( +0.0% ) 3.36 3.42 -1.9% 2.659 2.669
NANOmc106Xul16APVv2 2500.0002 3.048 3.048 0.000 ( +0.0% ) 3.35 3.11 +7.8% 2.672 2.685
NANOmc106Xul17v2 2500.0003 3.153 3.153 0.000 ( +0.0% ) 3.13 3.12 +0.4% 3.108 3.147
NANOmc106Xul18v2 2500.0004 3.105 3.105 0.000 ( +0.0% ) 3.19 3.14 +1.6% 3.132 3.125
NANOdata106Xul16v2 2500.0101 1.539 1.539 0.000 ( +0.0% ) 6.15 5.76 +6.7% 2.759 2.772
NANOdata106Xul17v2 2500.0102 1.926 1.926 0.000 ( +0.0% ) 3.85 3.87 -0.5% 2.865 2.970
NANOdata106Xul18v2 2500.0103 1.890 1.890 0.000 ( +0.0% ) 4.73 4.69 +0.7% 2.850 2.876
NANOmcUL16APVreMINI 2500.0201 0.022 0.022 0.000 ( +0.0% ) 1.81 1.69 +7.0% 2.870 2.921
NANOmcUL16reMINI 2500.0202 0.022 0.022 0.000 ( +0.0% ) 1.79 1.74 +2.6% 2.876 2.931
NANOmcUL17reMINI 2500.0203 0.022 0.022 0.000 ( +0.0% ) 1.64 1.54 +6.5% 3.065 3.063
NANOmcUL18reMINI 2500.0204 0.022 0.022 0.000 ( +0.0% ) 1.53 1.52 +0.7% 3.084 3.091
NANOdataUL16APVreMINI 2500.0301 0.035 0.035 0.000 ( +0.0% ) 1.48 1.49 -1.0% 2.786 2.822
NANOdataUL16reMINI 2500.0302 0.036 0.036 0.000 ( +0.0% ) 1.50 1.49 +0.5% 2.801 2.833
NANOdataUL17reMINI 2500.0303 0.037 0.037 0.000 ( +0.0% ) 1.50 1.44 +4.5% 2.826 2.862
NANOdataUL18reMINI 2500.0304 0.036 0.036 0.000 ( +0.0% ) 1.49 1.46 +1.8% 2.815 2.851
NANOmcUL16APVMini2Mini 2500.0401 0.023 0.023 0.000 ( +0.0% ) 2.35 2.37 -1.2% 2.111 2.115
NANOmcUL16Mini2Mini 2500.0402 0.023 0.023 0.000 ( +0.0% ) 2.52 2.45 +3.1% 2.140 2.144
NANOmcUL17Mini2Mini 2500.0403 0.023 0.023 0.000 ( +0.0% ) 2.32 2.23 +4.2% 2.165 2.162
NANOmcUL18Mini2Mini 2500.0404 0.023 0.023 0.000 ( +0.0% ) 2.41 2.29 +5.1% 2.167 2.157
NANOdataUL16Mini2Mini 2500.0501 0.039 0.039 0.000 ( +0.0% ) 3.53 3.38 +4.2% 2.005 2.002
NANOdataUL17Mini2Mini 2500.0502 0.040 0.040 0.000 ( +0.0% ) 2.57 2.55 +1.1% 2.062 2.069
NANOdataUL18Mini2Mini 2500.0503 0.039 0.039 0.000 ( +0.0% ) 3.06 2.94 +4.2% 2.055 2.057
NANOmc130X 2500.1001 3.228 3.228 0.000 ( +0.0% ) 3.74 3.86 -3.1% 3.058 2.518
NANOdata130Xrun3 2500.1101 1.790 1.790 0.000 ( +0.0% ) 6.34 6.03 +5.2% 2.738 2.756
NANOmc23Mini2Mini 2500.1201 0.022 0.022 0.000 ( +0.0% ) 2.76 2.58 +6.6% 2.036 2.035
NANOdata23Mini2Mini 2500.1301 0.041 0.041 0.000 ( +0.0% ) 3.58 3.39 +5.5% 2.328 2.326
ScoutingNANOdata124Xrun3 2500.1501 0.772 0.772 0.000 ( +0.0% ) 33.13 31.39 +5.6% 1.591 1.475
ScoutingNANOmonitordata124Xrun3 2500.1502 0.862 0.862 0.000 ( +0.0% ) 13.90 12.83 +8.3% 1.441 1.432
ScoutingNANOdata130Xrun3 2500.1503 1.251 1.251 0.000 ( +0.0% ) 24.66 22.32 +10.5% 1.566 1.490
ScoutingNANOmonitordata130Xrun3 2500.1504 1.297 1.297 0.000 ( +0.0% ) 10.51 9.66 +8.8% 1.401 1.397
muPOGNANOmc140X 2500.2201 2.269 2.269 0.000 ( +0.0% ) 5.44 5.11 +6.5% 2.262 2.090
EGMNANOmc140X 2500.2202 3.859 3.859 0.000 ( +0.0% ) 3.94 3.54 +11.2% 2.387 2.565
BTVNANOmc140X 2500.2203 10.475 10.475 0.000 ( +0.0% ) 2.48 2.15 +15.3% 2.451 2.743
jmeNANOmc140X 2500.2204 6.639 6.639 0.000 ( +0.0% ) 1.13 1.04 +8.2% 2.620 2.644
lepTrackInfoNANOmc140X 2500.2206 3.553 3.553 0.000 ( +0.0% ) 3.93 3.36 +17.2% 2.560 2.566
ScoutingNANOmc140X 2500.2207 1.488 1.488 0.000 ( +0.0% ) 13.64 12.70 +7.4% 1.784 1.859
ScoutingNANOwithPromptmc140X 2500.2208 4.461 4.461 0.000 ( +0.0% ) 2.59 2.68 -3.5% 2.578 2.728
muPOGNANO140Xrun3 2500.2301 1.683 1.683 0.000 ( +0.0% ) 7.55 7.20 +4.9% 2.334 2.612
EGMNANOdata140Xrun3 2500.2302 2.623 2.623 0.000 ( +0.0% ) 5.74 5.32 +8.1% 2.694 2.898
BTVNANOdata140Xrun3 2500.2303 5.612 5.612 0.000 ( +0.0% ) 3.57 3.45 +3.6% 2.777 3.072
jmeNANOdata140Xrun3 2500.2304 3.976 3.976 0.000 ( +0.0% ) 1.39 1.45 -3.8% 2.310 2.946
lepTrackInfoNANOdata140Xrun3 2500.2306 2.413 2.413 0.000 ( +0.0% ) 5.73 5.60 +2.3% 2.681 2.899
ScoutingNANOdata140Xrun3 2500.2307 1.101 1.101 0.000 ( +0.0% ) 29.33 29.72 -1.3% 1.364 1.591
ScoutingNANOmonitordata140Xrun3 2500.2308 2.784 2.784 0.000 ( +0.0% ) 4.16 4.26 -2.4% 2.670 2.953
ScoutingNANOmonitorWithPromptdata140Xrun3 2500.2309 2.784 2.784 0.000 ( +0.0% ) 4.05 4.31 -6.0% 2.707 2.954
L1ScoutingSelectionNANOdata140Xrun3 2500.2311 0.081 0.081 0.000 ( +0.0% ) 47.79 48.23 -0.9% 0.849 0.842
L1ScoutingNANOdata140Xrun3 2500.231 0.082 0.082 0.000 ( +0.0% ) 4.00 4.05 -1.1% 0.937 0.959
l1DPGNANO140Xrun3 2500.2401 9.405 9.405 0.000 ( +0.0% ) 6.54 6.68 -2.0% 1.843 1.845
muDPGNANO140Xrun3 2500.2402 10.377 10.377 0.000 ( +0.0% ) 1.55 1.63 -5.1% 1.689 1.693
muDPGNANOBkg140Xrun3 2500.2403 6.401 6.401 0.000 ( +0.0% ) 15.13 15.20 -0.5% 1.248 1.261
hcalDPGNANO140Xrun3 2500.2404 486.015 486.015 0.000 ( +0.0% ) 1.10 1.16 -4.6% 1.631 1.715
hcalDPGCalibNANO140Xrun3 2500.2405 826.418 826.418 0.000 ( +0.0% ) 1.39 1.50 -7.7% 1.613 1.697
hcalDPGMCNANO140Xrun3 2500.2501 645.333 645.333 0.000 ( +0.0% ) 1.53 1.63 -6.4% 1.802 1.807
NANOmc2024reMINI 2500.2601 0.021 0.021 0.000 ( +0.0% ) 1.82 1.96 -7.3% 2.989 2.999
NANOdata2024reMINI 2500.2701 0.036 0.036 0.000 ( +0.0% ) 1.68 1.92 -12.4% 2.510 2.780
NANOmc150X 2500.3001 3.224 3.224 0.000 ( +0.0% ) 13.94 15.87 -12.1% 2.773 2.779
NANOdata150X 2500.3101 2.144 2.144 0.000 ( +0.0% ) 26.88 32.90 -18.3% 2.215 2.522
NANOdata150X 2500.3102 2.630 2.630 0.000 ( +0.0% ) 24.68 28.44 -13.2% 2.308 2.598
muPOGNANOmc150X 2500.3201 2.344 2.344 0.000 ( +0.0% ) 11.37 15.57 -27.0% 2.401 2.037
EGMNANOmc150X 2500.3202 4.118 4.118 0.000 ( +0.0% ) 10.71 14.03 -23.7% 2.760 2.164
BTVNANOmc150X 2500.3203 10.559 10.559 0.000 ( +0.0% ) 3.94 4.33 -9.0% 2.332 2.375
jmeNANOmc150X 2500.3204 6.460 6.460 0.000 ( +0.0% ) 1.04 1.07 -2.9% 2.169 2.323
jmeNANOrePuppimc150X 2500.3205 6.464 6.464 0.000 ( +0.0% ) 0.90 0.89 +1.5% 2.517 2.501
lepTrackInfoNANOmc150X 2500.3206 3.728 3.728 0.000 ( +0.0% ) 13.84 12.42 +11.5% 2.761 2.760
ScoutingNANOmc150X 2500.3207 1.563 1.563 0.000 ( +0.0% ) 14.41 13.83 +4.2% 2.275 2.395
ScoutingNANOwithPromptmc150X 2500.3208 4.781 4.781 0.000 ( +0.0% ) 7.97 7.30 +9.3% 2.288 2.324
BPHNANOmc150X 2500.3209 4.135 4.135 0.000 ( +0.0% ) 12.16 11.27 +7.9% 2.348 2.836
EXONANOmc150X 2500.321 6.157 6.153 0.004 ( +0.1% ) 0.26 0.27 -4.0% 0.851 0.861
muPOGNANO150Xrun3 2500.3301 1.244 1.244 0.000 ( +0.0% ) 24.25 26.97 -10.1% 2.379 2.417
EGMNANOdata150Xrun3 2500.3302 2.985 2.985 0.000 ( +0.0% ) 20.77 22.39 -7.2% 2.280 2.198
BTVNANOdata150Xrun3 2500.3303 7.971 7.971 0.000 ( +0.0% ) 4.42 4.45 -0.5% 2.308 2.692
jmeNANOdata150Xrun3 2500.3304 4.349 4.349 0.000 ( +0.0% ) 1.15 1.08 +6.5% 2.062 2.359
jmeNANOrePuppidata150Xrun3 2500.3305 4.332 4.332 0.000 ( +0.0% ) 1.08 1.02 +6.4% 2.350 2.548
lepTrackInfoNANOdata150Xrun3 2500.3306 2.625 2.625 0.000 ( +0.0% ) 21.06 18.27 +15.2% 2.298 2.507
ScoutingNANOdata150Xrun3 2500.3307 1.738 1.738 0.000 ( +0.0% ) 23.32 19.58 +19.1% 1.404 1.570
ScoutingNANOmonitordata150Xrun3 2500.3308 1.400 1.400 0.000 ( +0.0% ) 18.01 17.15 +5.0% 2.274 2.252
ScoutingNANOmonitorWithPromptdata150Xrun3 2500.3309 2.602 2.602 0.000 ( +0.0% ) 12.98 12.84 +1.1% 2.327 2.174
EXONANOdata150Xrun3 2500.3311 5.269 5.267 0.002 ( +0.0% ) 0.25 0.21 +21.8% 0.782 0.800
L1ScoutingNANOdata150Xrun3 2500.3312 0.078 0.078 0.000 ( +0.0% ) 2.50 2.11 +18.5% 0.934 0.942
L1ScoutingSelectionNANOdata150Xrun3 2500.3313 0.078 0.078 0.000 ( +0.0% ) 19.45 17.16 +13.4% 0.960 0.956
BPHNANOdata150Xrun3 2500.331 2.632 2.632 0.000 ( +0.0% ) 20.31 19.63 +3.5% 2.248 2.356
L1ScoutingNANOdata160Xrun3 2500.4301 0.110 0.110 0.000 ( +0.0% ) 1.85 1.64 +12.6% 0.929 0.925
L1ScoutingSelectionNANOdata160Xrun3 2500.4302 0.113 0.113 0.000 ( +0.0% ) 13.90 13.60 +2.2% 0.847 0.961
TTbarMINIAOD10.6_UL18v2 2500.9001 1.814 1.814 0.000 ( +0.0% ) 27.00 24.50 +10.2% 1.905 1.913
TTbarMINIAOD14.0 2500.9002 1.662 1.662 0.000 ( +0.0% ) 27.86 23.57 +18.2% 1.502 1.504
DYToLL_M-50_13TeV_pythia8 2500.9101 14.992 14.992 0.000 ( +0.0% ) 6.35 5.11 +24.1% 1.154 1.157
DYToll01234Jets_5f_LO_MLM_Madgraph_LHE_13TeV 2500.9102 0.438 0.240 0.198 ( +82.7% ) 1.91 2.52 -24.2% 0.887 0.889
TTbar_Pow_LHE_13TeV 2500.9103 0.110 0.110 0.000 ( +0.0% ) 2.23 1.45 +53.7% 0.893 0.889

NANO Comparison Summary

Summary:

  • You potentially added 1081 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 43020
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 43020
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 192 log files, 112 edm output root files, 32 DQM output files
  • TriggerResults: no differences found

@quinnanm
Copy link
Copy Markdown
Contributor

DYToll01234Jets_5f_LO_MLM_Madgraph_LHE_13TeV shows a big change but I'm guessing it's unrelated?

@smorovic
Copy link
Copy Markdown
Contributor

+1

@missirol
Copy link
Copy Markdown
Contributor Author

missirol commented May 19, 2026

DYToll01234Jets_5f_LO_MLM_Madgraph_LHE_13TeV shows a big change but I'm guessing it's unrelated?

Mh, good catch. Yes, I think it's unrelated.

As to why this wf behaves this way, I don't know.

  • Maybe it has to do with the use of "MLM"? (Edit : this does not seem to be the case, as there are differences already at the LHE level.)
  • Is there a way to make it fully deterministic? (If not, maybe it is not the best choice for PR tests.)

The latter questions are maybe for XPOG or GEN, and anyway beyond the scope of this PR.

@quinnanm
Copy link
Copy Markdown
Contributor

+l1

@battibass
Copy link
Copy Markdown

We confirm that the behaviour of DYToll01234Jets_5f_LO_MLM_Madgraph_LHE_13TeV is "as expected".

@battibass
Copy link
Copy Markdown

+xpog

@cmsbuild
Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

@missirol
Copy link
Copy Markdown
Contributor Author

We confirm that the behaviour of DYToll01234Jets_5f_LO_MLM_Madgraph_LHE_13TeV is "as expected".

Fwiw, out of curiosity I checked what happens with a few different gridpacks, and I think I get non-reproducible LHE outputs with [1], and reproducible ones with [2]. I didn't investigate further (the "issue" might be due to using an old version of MadGraph, or CMSSW, or else; the problem occurs with both slc6 and slc7 gridpacks). In short, using a more recent gridpack might be enough to fix this.

[1] The first one corresponds to the one currently used in wf 2500.9102.

/cvmfs/cms.cern.ch/phys_generator/gridpacks/UL/13TeV/madgraph/V5_2.6.5/dyellell01234j_5f_LO_MLM_v2/DYJets_HT-incl_slc6_amd64_gcc630_CMSSW_9_3_16_tarball.tar.xz
/cvmfs/cms.cern.ch/phys_generator/gridpacks/UL/13TeV/madgraph/V5_2.6.5/DYJets_M50_LT_0to2000/DYJets_M50_LT_200to400_slc6_amd64_gcc630_CMSSW_9_3_16_tarball.tar.xz
/cvmfs/cms.cern.ch/phys_generator/gridpacks/UL/13TeV/madgraph/V5_2.6.5/LQ_TT_CMuTau/LQ_cmutau_v2_slc6_amd64_gcc700_CMSSW_10_2_19_tarball.tar.xz
/cvmfs/cms.cern.ch/phys_generator/gridpacks/UL/13TeV/madgraph/V5_2.6.5/dyellell01234j_5f_LO_MLM/dyellell01234j_5f_LO_MLM_slc7_amd64_gcc630_CMSSW_9_3_8_tarball.tar.xz

[2]

/cvmfs/cms.cern.ch/phys_generator/gridpacks/PdmV/RunIII2024Summer24/MadGraph5_aMCatNLO/DY/DYto2L-4Jets_Bin-MLL-50_madgraphMLM-pythia8_slc7_amd64_gcc10_CMSSW_12_4_8_tarball_original_Run3_wo_runcmsgrid_sys_patch.tar.xz
/cvmfs/cms.cern.ch/phys_generator/gridpacks/UL/13TeV/madgraph/V5_3.3.1/ttWJetsToLNu_5f/TTWJetsToLNu_5f_NLO_FXFX_slc7_amd64_gcc900_CMSSW_12_0_2_tarball.tar.xz

@mandrenguyen
Copy link
Copy Markdown
Contributor

+1

@cmsbuild cmsbuild merged commit 055941f into cms-sw:master May 20, 2026
12 checks passed
@missirol missirol deleted the devel_cmssw50636 branch May 20, 2026 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants